lkml.org 
[lkml]   [2017]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] Motorola Droid 4 Audio Support
Hi,

On Fri, Jul 07, 2017 at 10:27:53PM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170707 09:43]:
> > I got working sound on Droid 4 with mainline \o/. The codec is
> > currently missing support for detecting if something has been
> > plugged into the 3.5mm connector, since that seems to require
> > some closed source firmware and needs further investigation. I
> > think this can be added later.
>
> Hey that's great! I'll give it a try this weekend.. Does that mean
> that 3G voice calls work too now or is something more needed there?

I added some text about that in the 3rd patch. Basically the codec driver
is ready (maybe a few quirks will be needed, though), but the soundcard
driver is not. It currently assumes CPU <-> Voice Codec, but
actually its a network of CPU, Voice Codec, Modem(s?) and Bluetooth.

> For the CPCAP PMIC macro interrupts I think it's best to set up
> a separate driver as it seems separate from the core CPCAP
> functionality. So I think we can just move the unused "cpcap-m2"
> IRQ banks out of motorola-cpcap.c and put them into a separate child
> driver that loads it's firmware on init and provides interrupts for
> the 3.5mm connector.

I also think the macro block fw handling should not be handled in
the driver for the audio codec. IIRC it is also used to provide a
blink feature for the status LEDs. OTOH some of the registers of the
audio-codec are also used for 3.5mm detection. I also did not yet look
into the details of this one.

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-07-08 13:34    [W:0.100 / U:11.612 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site