lkml.org 
[lkml]   [2017]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] mux: mux-core: Add NULL check for dev->of_node
From
Date
On 2017-07-07 23:46, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> If dev->of_node is NULL, then calling mux_control_get()
> function can lead to NULL pointer exception. So adding
> a NULL check for dev->of_node.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Do you have a driver that might call mux_control_get and not have any
of_node? If not, I don't see the point of this check.

Cheers,
peda

> ---
> drivers/mux/mux-core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Changes since v1:
> * Removed dummy new line.
>
> diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c
> index 90b8995..924c983 100644
> --- a/drivers/mux/mux-core.c
> +++ b/drivers/mux/mux-core.c
> @@ -438,6 +438,9 @@ struct mux_control *mux_control_get(struct device *dev, const char *mux_name)
> int index = 0;
> int ret;
>
> + if (!np)
> + return ERR_PTR(-ENODEV);
> +
> if (mux_name) {
> index = of_property_match_string(np, "mux-control-names",
> mux_name);
>

\
 
 \ /
  Last update: 2017-07-08 23:01    [W:0.088 / U:8.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site