lkml.org 
[lkml]   [2017]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/1] mux: mux-core: Unregister mux_class in mux_exit()
From
Date
On 2017-07-07 23:50, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Good catch!

However, I do not like the empty commit message, please add a sentence
about how this fixes a typo or something, and also please add this tag:

Fixes: a3b02a9c6591 ("mux: minimal mux subsystem")

Cheers,
peda

> ---
> drivers/mux/mux-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c
> index 90b8995..2fe96c4 100644
> --- a/drivers/mux/mux-core.c
> +++ b/drivers/mux/mux-core.c
> @@ -46,7 +46,7 @@ static int __init mux_init(void)
>
> static void __exit mux_exit(void)
> {
> - class_register(&mux_class);
> + class_unregister(&mux_class);
> ida_destroy(&mux_ida);
> }
>
>

\
 
 \ /
  Last update: 2017-07-08 22:58    [W:0.041 / U:105.012 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site