lkml.org 
[lkml]   [2017]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: hwmon: adc128d818: constify attribute_group structures.
On Wed, Jul 05, 2017 at 10:52:13AM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2304 2936 0 5240 1478 drivers/hwmon/adc128d818.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2344 2872 0 5216 1460 drivers/hwmon/adc128d818.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/adc128d818.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/adc128d818.c b/drivers/hwmon/adc128d818.c
> index a557b46..bd2ca31 100644
> --- a/drivers/hwmon/adc128d818.c
> +++ b/drivers/hwmon/adc128d818.c
> @@ -384,7 +384,7 @@ static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO,
> NULL
> };
>
> -static struct attribute_group adc128_group = {
> +static const struct attribute_group adc128_group = {
> .attrs = adc128_attrs,
> .is_visible = adc128_is_visible,
> };

\
 
 \ /
  Last update: 2017-07-08 17:57    [W:0.038 / U:3.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site