lkml.org 
[lkml]   [2017]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: hwmon: nct7802: constify attribute_group structures.
On Wed, Jul 05, 2017 at 10:36:33AM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 6655 304 0 6959 1b2f drivers/hwmon/hwmon.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6703 240 0 6943 1b1f drivers/hwmon/hwmon.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/nct7802.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
> index 12b94b0..2876c18 100644
> --- a/drivers/hwmon/nct7802.c
> +++ b/drivers/hwmon/nct7802.c
> @@ -704,7 +704,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj,
> return attr->mode;
> }
>
> -static struct attribute_group nct7802_temp_group = {
> +static const struct attribute_group nct7802_temp_group = {
> .attrs = nct7802_temp_attrs,
> .is_visible = nct7802_temp_is_visible,
> };
> @@ -802,7 +802,7 @@ static umode_t nct7802_in_is_visible(struct kobject *kobj,
> return attr->mode;
> }
>
> -static struct attribute_group nct7802_in_group = {
> +static const struct attribute_group nct7802_in_group = {
> .attrs = nct7802_in_attrs,
> .is_visible = nct7802_in_is_visible,
> };
> @@ -880,7 +880,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj,
> return attr->mode;
> }
>
> -static struct attribute_group nct7802_fan_group = {
> +static const struct attribute_group nct7802_fan_group = {
> .attrs = nct7802_fan_attrs,
> .is_visible = nct7802_fan_is_visible,
> };
> @@ -898,7 +898,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj,
> NULL
> };
>
> -static struct attribute_group nct7802_pwm_group = {
> +static const struct attribute_group nct7802_pwm_group = {
> .attrs = nct7802_pwm_attrs,
> };
>
> @@ -1011,7 +1011,7 @@ static SENSOR_DEVICE_ATTR(pwm3_auto_point4_pwm, S_IRUGO | S_IWUSR,
> NULL
> };
>
> -static struct attribute_group nct7802_auto_point_group = {
> +static const struct attribute_group nct7802_auto_point_group = {
> .attrs = nct7802_auto_point_attrs,
> };
>

\
 
 \ /
  Last update: 2017-07-08 17:54    [W:0.032 / U:11.732 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site