Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH] arcnet: com20020-pci: Fix an error handling path in 'com20020pci_probe()' | Date | Fri, 7 Jul 2017 06:56:16 +0200 |
| |
If this memory allocation fails, we should go through the error handling path as done everywhere else in this function before returning.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/arcnet/com20020-pci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index 239de38fbd6a..8e89a2ac071e 100644 --- a/drivers/net/arcnet/com20020-pci.c +++ b/drivers/net/arcnet/com20020-pci.c @@ -196,8 +196,10 @@ static int com20020pci_probe(struct pci_dev *pdev, card = devm_kzalloc(&pdev->dev, sizeof(struct com20020_dev), GFP_KERNEL); - if (!card) - return -ENOMEM; + if (!card) { + ret = -ENOMEM; + goto out_port; + } card->index = i; card->pci_priv = priv; -- 2.11.0
| |