Messages in this thread | | | Date | Thu, 6 Jul 2017 09:18:40 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 2/8] usb: bdc: Add Device Tree binding document for Broadcom BDC driver |
| |
On Tue, Jun 27, 2017 at 02:23:20PM -0400, Al Cooper wrote: > Add Device Tree binding document for Broadcom USB Device > Controller (BDC). > > Signed-off-by: Al Cooper <alcooperx@gmail.com> > --- > .../devicetree/bindings/usb/brcm,bdc-udc.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt > > diff --git a/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt b/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt > new file mode 100644 > index 0000000..4eeaddb > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt > @@ -0,0 +1,28 @@ > +Broadcom USB Device Controller (BDC) > +==================================== > + > +Required properties: > + > +- compatible: must be one of: > + "brcm,bdc-udc-v0.16" > + "brcm,bdc-udc"
Isn't "bdc-udc" redundant?
Where does the version number come from?
> +- reg: the base register address and length > +- interrupts: ther interrupt line for this controller
s/ther/the/
> + > +Optional properties: > + > +On Broadcom STB platforms, these properties are required: > + > +- phys: phandle to the USB PHY blocks
How many?
> +- clocks: phandle to the functional clock of this block > + > +Example: > + > + udc@f0b02000 { > + status = "disabled";
Don't show status in examples.
> + compatible = "brcm,bdc-udc-v0.16"; > + reg = <0xf0b02000 0xfc4>; > + interrupts = <0x0 0x60 0x0>; > + phys = <&usbphy_0 0x0>; > + clocks = <&sw_usbd>; > + }; > -- > 1.9.0.138.g2de3478 >
| |