lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 13/14] drm: stm: remove dead code and pointless local lut storage
    Date
    The redundant fb helper .load_lut is no longer used, and can not
    work right without also providing the fb helpers .gamma_set and
    .gamma_get thus rendering the code in this driver suspect.

    Just remove the dead code.

    Signed-off-by: Peter Rosin <peda@axentia.se>
    ---
    drivers/gpu/drm/stm/ltdc.c | 12 ------------
    drivers/gpu/drm/stm/ltdc.h | 1 -
    2 files changed, 13 deletions(-)

    diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
    index 5331760..3e95b4d 100644
    --- a/drivers/gpu/drm/stm/ltdc.c
    +++ b/drivers/gpu/drm/stm/ltdc.c
    @@ -375,17 +375,6 @@ static irqreturn_t ltdc_irq(int irq, void *arg)
    * DRM_CRTC
    */

    -static void ltdc_crtc_load_lut(struct drm_crtc *crtc)
    -{
    - struct ltdc_device *ldev = crtc_to_ltdc(crtc);
    - unsigned int i, lay;
    -
    - for (lay = 0; lay < ldev->caps.nb_layers; lay++)
    - for (i = 0; i < 256; i++)
    - reg_write(ldev->regs, LTDC_L1CLUTWR + lay * LAY_OFS,
    - ldev->clut[i]);
    -}
    -
    static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
    struct drm_crtc_state *old_state)
    {
    @@ -525,7 +514,6 @@ static void ltdc_crtc_atomic_flush(struct drm_crtc *crtc,
    }

    static struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = {
    - .load_lut = ltdc_crtc_load_lut,
    .mode_set_nofb = ltdc_crtc_mode_set_nofb,
    .atomic_flush = ltdc_crtc_atomic_flush,
    .atomic_enable = ltdc_crtc_atomic_enable,
    diff --git a/drivers/gpu/drm/stm/ltdc.h b/drivers/gpu/drm/stm/ltdc.h
    index d7a9c73..620ca55 100644
    --- a/drivers/gpu/drm/stm/ltdc.h
    +++ b/drivers/gpu/drm/stm/ltdc.h
    @@ -27,7 +27,6 @@ struct ltdc_device {
    struct drm_panel *panel;
    struct mutex err_lock; /* protecting error_status */
    struct ltdc_caps caps;
    - u32 clut[256]; /* color look up table */
    u32 error_status;
    u32 irq_status;
    };
    --
    2.1.4
    \
     
     \ /
      Last update: 2017-07-06 14:21    [W:2.176 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site