lkml.org 
[lkml]   [2017]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch V2 1/2] mm: swap: Provide lru_add_drain_all_cpuslocked()
    On Tue, 4 Jul 2017, Vlastimil Babka wrote:
    > >
    > > -void lru_add_drain_all(void)
    > > +void lru_add_drain_all_cpuslocked(void)
    > > {
    > > static DEFINE_MUTEX(lock);
    > > static struct cpumask has_work;
    > > @@ -701,7 +701,6 @@ void lru_add_drain_all(void)
    > > return;
    > >
    > > mutex_lock(&lock);
    > > - get_online_cpus();
    >
    > Is there a an assertion check that we are locked, that could be put in
    > e.g. VM_WARN_ON_ONCE()?

    There is a lockdep assertion lockdep_assert_cpus_held() which could be
    used. Forgot to add it.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2017-07-04 14:36    [W:4.223 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site