[lkml]   [2017]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h
2017-07-04 19:06 GMT+09:00 Andy Shevchenko <>:
> On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote:
>> Some of include directives in include/linux/gpio/driver.h are
>> unneeded because the header does not need to know the content of
>> struct device, irq_chip, etc. Just declare they are structures.
>> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
>> turned out to be necessary for irq_flow_handler_t and spinlock_t,
>> respectively.
>> Each driver should include what it needs without relying on what is
>> implicitly included from <linux/gpio/driver.h>. This will cut down
>> unnecessary header parsing.
> If Linus is okay with the following proposal I would rather go with it,
> i.e. logical split the series to
> 1. Fix IRQ related headers inclusion
> 2. Fix pinconf-generic.h inclusion
> 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)

4. Fix (platform_)device inclusion

But, I do not see much sense to touch headers multiple times.

Best Regards
Masahiro Yamada

 \ /
  Last update: 2017-07-04 12:40    [W:0.123 / U:7.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site