lkml.org 
[lkml]   [2017]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook
On Mon, 31 Jul 2017, Kees Cook wrote:

> The Smack bprm_secureexec hook can be merged with the bprm_set_creds
> hook since it's dealing with the same information, and all of the details
> are finalized during the first call to the bprm_set_creds hook via
> prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored
> via bprm->called_set_creds).
>
> Here, the test can just happen at the end of the bprm_set_creds hook,
> and the bprm_secureexec hook can be dropped.
>
> Cc: Casey Schaufler <casey@schaufler-ca.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Acked-by: Serge Hallyn <serge@hallyn.com>
> ---
> security/smack/smack_lsm.c | 21 ++++-----------------
> 1 file changed, 4 insertions(+), 17 deletions(-)


Reviewed-by: James Morris <james.l.morris@oracle.com>


--
James Morris
<jmorris@namei.org>

\
 
 \ /
  Last update: 2017-08-01 02:48    [W:0.535 / U:15.404 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site