Messages in this thread | | | Date | Tue, 1 Aug 2017 10:45:54 +1000 (AEST) | From | James Morris <> | Subject | Re: [PATCH v4 05/15] selinux: Refactor to remove bprm_secureexec hook |
| |
On Mon, 31 Jul 2017, Kees Cook wrote:
> The SELinux bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored > via bprm->called_set_creds). > > Here, the test can just happen at the end of the bprm_set_creds hook, > and the bprm_secureexec hook can be dropped. > > Cc: Stephen Smalley <sds@tycho.nsa.gov> > Signed-off-by: Kees Cook <keescook@chromium.org> > Acked-by: Paul Moore <paul@paul-moore.com> > Tested-by: Paul Moore <paul@paul-moore.com> > Acked-by: Serge Hallyn <serge@hallyn.com> > --- > security/selinux/hooks.c | 24 +++++------------------- > 1 file changed, 5 insertions(+), 19 deletions(-)
Reviewed-by: James Morris <james.l.morris@oracle.com>
-- James Morris <jmorris@namei.org>
| |