lkml.org 
[lkml]   [2017]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 05/15] selinux: Refactor to remove bprm_secureexec hook
    On Mon, 31 Jul 2017, Kees Cook wrote:

    > The SELinux bprm_secureexec hook can be merged with the bprm_set_creds
    > hook since it's dealing with the same information, and all of the details
    > are finalized during the first call to the bprm_set_creds hook via
    > prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored
    > via bprm->called_set_creds).
    >
    > Here, the test can just happen at the end of the bprm_set_creds hook,
    > and the bprm_secureexec hook can be dropped.
    >
    > Cc: Stephen Smalley <sds@tycho.nsa.gov>
    > Signed-off-by: Kees Cook <keescook@chromium.org>
    > Acked-by: Paul Moore <paul@paul-moore.com>
    > Tested-by: Paul Moore <paul@paul-moore.com>
    > Acked-by: Serge Hallyn <serge@hallyn.com>
    > ---
    > security/selinux/hooks.c | 24 +++++-------------------
    > 1 file changed, 5 insertions(+), 19 deletions(-)


    Reviewed-by: James Morris <james.l.morris@oracle.com>


    --
    James Morris
    <jmorris@namei.org>

    \
     
     \ /
      Last update: 2017-08-01 02:47    [W:4.172 / U:0.716 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site