Messages in this thread | | | From | Brendan Higgins <> | Date | Mon, 31 Jul 2017 11:20:29 -0700 | Subject | Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference |
| |
On Mon, Jul 31, 2017 at 2:27 AM, Joel Stanley <joel@jms.id.au> wrote: > On Sat, Jul 29, 2017 at 10:30 AM, Brendan Higgins > <brendanhiggins@google.com> wrote: >> Before I skipped null checks when the master is in the STOP state; this >> fixes that. >> >> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > Acked-by: Joel Stanley <joel@jms.id.au> > > Out of interest, was this found by code review, or did you hit this in testing?
I am pretty sure we hit it in testing. Unfortunately, we had trouble reproducing it, but we did see a null pointer dereference.
> > Cheers, > > Joel
| |