lkml.org 
[lkml]   [2017]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH]: x86: clarify/fix no-op barriers for text_poke_bp()
On Mon, Jul 31, 2017 at 10:23:23AM -0400, Steven Rostedt wrote:
> > - smp_wmb();
>
> Heh, I think this was a "lets not leak bp_patching_in_progress" out of
> this function. But I don't see any harm if it happens.
>
> As this function was a *very* slow path, that smp_wmb() was a "it's not
> really needed, but it wont hurt anything to slap it in there just in
> case".

Well, this is x86, its a NO-OP. The only reason to write barriers like
that is for documentation purposes and in that regard is confuses. IOW
has negative value.


\
 
 \ /
  Last update: 2017-07-31 17:05    [W:0.081 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site