lkml.org 
[lkml]   [2017]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.
    On 28 July 2017 at 17:26, Martijn Coenen <maco@android.com> wrote:
    > Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
    > was incomplete and didn't update a check in binder_mmap(), causing all
    > mmap() calls into the binder driver to fail.
    >

    Fixes Android WiFi/BT regression reported on 4.13-rc2.

    Tested-by: Amit Pundir <amit.pundir@linaro.org>

    > Signed-off-by: Martijn Coenen <maco@android.com>
    > ---
    > drivers/android/binder.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
    > index f7665c31feca..831cdd7d197d 100644
    > --- a/drivers/android/binder.c
    > +++ b/drivers/android/binder.c
    > @@ -3362,7 +3362,7 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
    > const char *failure_string;
    > struct binder_buffer *buffer;
    >
    > - if (proc->tsk != current)
    > + if (proc->tsk != current->group_leader)
    > return -EINVAL;
    >
    > if ((vma->vm_end - vma->vm_start) > SZ_4M)
    > --
    > 2.14.0.rc0.400.g1c36432dff-goog
    >

    \
     
     \ /
      Last update: 2017-07-31 07:26    [W:6.763 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site