Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 3 Jul 2017 19:37:59 +0300 | Subject | Re: [PATCH] coccinelle: api: detect unnecessary le16_to_cpu |
| |
On Mon, Jul 3, 2017 at 4:36 PM, Sebastian Reichel <sebastian.reichel@collabora.co.uk> wrote: > On Sat, Jul 01, 2017 at 09:28:10PM +0200, Julia Lawall wrote:
> * drivers/gpio/gpio-pca953x.c (line 190-192)
It has double conversion there: 1. LE CPU: Read as LE and converted to LE (no-op), so, just u16 2. BE CPU: Read as BE and converted to LE, makes it __le16
Looks like the conversion is not needed, only get_unaligned() is necessary.
P.S. What about lines 244-245 there? I think they are no-op. Interesting that those two parts were added in quite different commits.
-- With Best Regards, Andy Shevchenko
| |