lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 002/101] net: dont call strlen on non-terminated string in dev_set_alias()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alexander Potapenko <glider@google.com>


    [ Upstream commit c28294b941232931fbd714099798eb7aa7e865d7 ]

    KMSAN reported a use of uninitialized memory in dev_set_alias(),
    which was caused by calling strlcpy() (which in turn called strlen())
    on the user-supplied non-terminated string.

    Signed-off-by: Alexander Potapenko <glider@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/core/dev.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/core/dev.c
    +++ b/net/core/dev.c
    @@ -1246,8 +1246,9 @@ int dev_set_alias(struct net_device *dev
    if (!new_ifalias)
    return -ENOMEM;
    dev->ifalias = new_ifalias;
    + memcpy(dev->ifalias, alias, len);
    + dev->ifalias[len] = 0;

    - strlcpy(dev->ifalias, alias, len+1);
    return len;
    }


    \
     
     \ /
      Last update: 2017-07-03 17:12    [W:4.159 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site