lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 033/101] scsi: sd: Fix wrong DPOFUA disable in sd_read_cache_type
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Damien Le Moal <damien.lemoal@wdc.com>


    [ Upstream commit 26f2819772af891dee2843e1f8662c58e5129d5f ]

    Zoned block devices force the use of READ/WRITE(16) commands by setting
    sdkp->use_16_for_rw and clearing sdkp->use_10_for_rw. This result in
    DPOFUA always being disabled for these drives as the assumed use of
    the deprecated READ/WRITE(6) commands only looks at sdkp->use_10_for_rw.
    Strenghten the test by also checking that sdkp->use_16_for_rw is false.

    Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
    Reviewed-by: Hannes Reinecke <hare@suse.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/sd.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/scsi/sd.c
    +++ b/drivers/scsi/sd.c
    @@ -2566,7 +2566,8 @@ sd_read_cache_type(struct scsi_disk *sdk
    if (sdp->broken_fua) {
    sd_first_printk(KERN_NOTICE, sdkp, "Disabling FUA\n");
    sdkp->DPOFUA = 0;
    - } else if (sdkp->DPOFUA && !sdkp->device->use_10_for_rw) {
    + } else if (sdkp->DPOFUA && !sdkp->device->use_10_for_rw &&
    + !sdkp->device->use_16_for_rw) {
    sd_first_printk(KERN_NOTICE, sdkp,
    "Uses READ/WRITE(6), disabling FUA\n");
    sdkp->DPOFUA = 0;

    \
     
     \ /
      Last update: 2017-07-03 17:07    [W:2.506 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site