lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 097/101] cpufreq: s3c2416: double free on driver init error path
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit a69261e4470d680185a15f748d9cdafb37c57a33 upstream.

    The "goto err_armclk;" error path already does a clk_put(s3c_freq->hclk);
    so this is a double free.

    Fixes: 34ee55075265 ([CPUFREQ] Add S3C2416/S3C2450 cpufreq driver)
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/cpufreq/s3c2416-cpufreq.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/cpufreq/s3c2416-cpufreq.c
    +++ b/drivers/cpufreq/s3c2416-cpufreq.c
    @@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(s
    rate = clk_get_rate(s3c_freq->hclk);
    if (rate < 133 * 1000 * 1000) {
    pr_err("cpufreq: HCLK not at 133MHz\n");
    - clk_put(s3c_freq->hclk);
    ret = -EINVAL;
    goto err_armclk;
    }

    \
     
     \ /
      Last update: 2017-07-03 16:49    [W:3.034 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site