lkml.org 
[lkml]   [2017]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tinydrm: repaper: add CONFIG_THERMAL dependency
From
Date

Den 27.07.2017 11.58, skrev Arnd Bergmann:
> The new RePaper driver uses the thermal subsystem, and fails to link
> when it is built-in but thermal is a loadable module:
>
> drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe':
> repaper.c:(.text+0x540): undefined reference to `thermal_zone_get_zone_by_name'
> drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_fb_dirty':
> repaper.c:(.text+0xff4): undefined reference to `thermal_zone_get_temp'
>
> This adds another Kconfig dependency to prevent the broken configuration,
> forcing repaper to be a module too.
>
> Fixes: 3589211e9b03 ("drm/tinydrm: Add RePaper e-ink driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks for fixing this, applied to drm-misc.

Noralf.

> drivers/gpu/drm/tinydrm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> index 9596e447f877..f17c3caceab2 100644
> --- a/drivers/gpu/drm/tinydrm/Kconfig
> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> @@ -23,6 +23,7 @@ config TINYDRM_MI0283QT
> config TINYDRM_REPAPER
> tristate "DRM support for Pervasive Displays RePaper panels (V231)"
> depends on DRM_TINYDRM && SPI
> + depends on THERMAL || !THERMAL
> help
> DRM driver for the following Pervasive Displays panels:
> 1.44" TFT EPD Panel (E1144CS021)

\
 
 \ /
  Last update: 2017-07-29 14:44    [W:0.042 / U:2.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site