lkml.org 
[lkml]   [2017]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim
Hi Michal,

[auto build test ERROR on cgroup/for-next]
[also build test ERROR on v4.13-rc2 next-20170728]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Michal-Hocko/mm-oom-do-not-rely-on-TIF_MEMDIE-for-memory-reserves-access/20170728-101955
base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: i386-randconfig-c0-07291424 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

In file included from include/linux/ioport.h:12:0,
from include/linux/device.h:16,
from include/linux/node.h:17,
from include/linux/cpu.h:16,
from kernel/cgroup/cpuset.c:25:
kernel/cgroup/cpuset.c: In function '__cpuset_node_allowed':
>> include/linux/compiler.h:123:18: error: implicit declaration of function 'tsk_is_oom_victim' [-Werror=implicit-function-declaration]
static struct ftrace_likely_data \
^
include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
kernel/cgroup/cpuset.c:2546:2: note: in expansion of macro 'if'
if (unlikely(tsk_is_oom_victim(current)))
^
include/linux/compiler.h:146:24: note: in expansion of macro '__branch_check__'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^
kernel/cgroup/cpuset.c:2546:6: note: in expansion of macro 'unlikely'
if (unlikely(tsk_is_oom_victim(current)))
^
cc1: some warnings being treated as errors
--
In file included from include/linux/ioport.h:12:0,
from include/linux/device.h:16,
from include/linux/node.h:17,
from include/linux/cpu.h:16,
from kernel//cgroup/cpuset.c:25:
kernel//cgroup/cpuset.c: In function '__cpuset_node_allowed':
>> include/linux/compiler.h:123:18: error: implicit declaration of function 'tsk_is_oom_victim' [-Werror=implicit-function-declaration]
static struct ftrace_likely_data \
^
include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
kernel//cgroup/cpuset.c:2546:2: note: in expansion of macro 'if'
if (unlikely(tsk_is_oom_victim(current)))
^
include/linux/compiler.h:146:24: note: in expansion of macro '__branch_check__'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^
kernel//cgroup/cpuset.c:2546:6: note: in expansion of macro 'unlikely'
if (unlikely(tsk_is_oom_victim(current)))
^
cc1: some warnings being treated as errors

vim +/tsk_is_oom_victim +123 include/linux/compiler.h

1f0d69a9 Steven Rostedt 2008-11-12 120
d45ae1f7 Steven Rostedt (VMware 2017-01-17 121) #define __branch_check__(x, expect, is_constant) ({ \
1f0d69a9 Steven Rostedt 2008-11-12 122 int ______r; \
134e6a03 Steven Rostedt (VMware 2017-01-19 @123) static struct ftrace_likely_data \
1f0d69a9 Steven Rostedt 2008-11-12 124 __attribute__((__aligned__(4))) \
45b79749 Steven Rostedt 2008-11-21 125 __attribute__((section("_ftrace_annotated_branch"))) \
1f0d69a9 Steven Rostedt 2008-11-12 126 ______f = { \
134e6a03 Steven Rostedt (VMware 2017-01-19 127) .data.func = __func__, \
134e6a03 Steven Rostedt (VMware 2017-01-19 128) .data.file = __FILE__, \
134e6a03 Steven Rostedt (VMware 2017-01-19 129) .data.line = __LINE__, \
1f0d69a9 Steven Rostedt 2008-11-12 130 }; \
d45ae1f7 Steven Rostedt (VMware 2017-01-17 131) ______r = __builtin_expect(!!(x), expect); \
d45ae1f7 Steven Rostedt (VMware 2017-01-17 132) ftrace_likely_update(&______f, ______r, \
d45ae1f7 Steven Rostedt (VMware 2017-01-17 133) expect, is_constant); \
1f0d69a9 Steven Rostedt 2008-11-12 134 ______r; \
1f0d69a9 Steven Rostedt 2008-11-12 135 })
1f0d69a9 Steven Rostedt 2008-11-12 136

:::::: The code at line 123 was first introduced by commit
:::::: 134e6a034cb004ed5acd3048792de70ced1c6cf5 tracing: Show number of constants profiled in likely profiler

:::::: TO: Steven Rostedt (VMware) <rostedt@goodmis.org>
:::::: CC: Steven Rostedt (VMware) <rostedt@goodmis.org>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2017-07-29 10:34    [W:0.261 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site