Messages in this thread | | | Date | Fri, 28 Jul 2017 21:17:26 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH] iommu/exynos: prevent building on big-endian kernels |
| |
On Fri, Jul 28, 2017 at 03:19:19PM +0200, Arnd Bergmann wrote: > Since we print the correct warning, an allmodconfig build is no longer > clean but always prints it, which defeats compile-testing: > > drivers/iommu/exynos-iommu.c:58:2: error: #warning "revisit driver if we can enable big-endian ptes" [-Werror=cpp] > > This replaces the #warning with a dependency, moving warning text into > a comment. > > Fixes: 1f59adb1766d ("iommu/exynos: Replace non-existing big-endian Kconfig option") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/iommu/Kconfig | 1 + > drivers/iommu/exynos-iommu.c | 4 ---- > 2 files changed, 1 insertion(+), 4 deletions(-) >
Makes sense, although there is no error to fix (for fixes tag). If there was an error, then probably the one bringing warning and wrong kconfig option (6ae5343c26f9cba5e9ef8 "iommu/exynos: update to use iommu big-endian")?
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards, Krzysztof
| |