Messages in this thread | | | Subject | Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly | From | Florian Fainelli <> | Date | Fri, 28 Jul 2017 10:05:06 -0700 |
| |
On 07/28/2017 09:55 AM, Vivien Didelot wrote: > Hi Egil, > > Egil Hjelmeland <privat@egil-hjelmeland.no> writes: > >>>> +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { >>>> + .phy_read = lan9303_indirect_phy_read, >>>> + .phy_write = lan9303_indirect_phy_write, >>>> +}; >>>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops); >>> >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? >> >> I have no opinion. I just used the same variant as the other EXPORTS >> in the file. > > If there is no concern from others about this, LGTM too:
Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem to be appropriate, which can be done as a subsequent patch.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |