lkml.org 
[lkml]   [2017]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL
On Fri, 28 Jul 2017, Arnd Bergmann wrote:

> Matt Hart reports that vf610m4_defconfig kernels grew to 2GB
> xipImage size after the __bug_table change.
>
> I tried out a few things and found that moving the bug table
> into the .data section avoids this problem. However, the
> linker script magic is beyond my capabilities here, so this
> is almost certainly not correct.

Well, before your patch the BUG_TABLE location as well as its runtime
functionality were completely wrong and broken.

> I've added a few people to Cc that understand this better
> than I do, hopefully someone can turn my bogus patch into
> a proper one.

Your patch isn't as bad as you make it, but maybe the following will
avoid open recoding BUG_TABLE locally:

diff --git a/arch/arm/kernel/vmlinux-xip.lds.S b/arch/arm/kernel/vmlinux-xip.lds.S
index 8265b11621..21b4b29c2f 100644
--- a/arch/arm/kernel/vmlinux-xip.lds.S
+++ b/arch/arm/kernel/vmlinux-xip.lds.S
@@ -237,13 +237,13 @@ SECTIONS
*/
DATA_DATA
CONSTRUCTORS
-
- _edata = .;
}
- _edata_loc = __data_loc + SIZEOF(.data);

BUG_TABLE

+ _edata = .;
+ _edata_loc = __data_loc + SIZEOF(.data);
+
#ifdef CONFIG_HAVE_TCM
/*
* We align everything to a page boundary so we can

Nicolas

\
 
 \ /
  Last update: 2017-07-28 17:28    [W:0.046 / U:32.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site