[lkml]   [2017]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v2 0/3] ASoC: fix unbalanced of_node_get()/of_node_put()
From: Antonio Borneo <>

On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several
errors at kernel boot, like
OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0
OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0/endpoint
each followed by stack dump.

Fixed by:
- removing of_node_put() in the body of of_for_each_phandle(){},
since already provided at each iteration. Add it in case the
loop is break out;
- adding of_node_get() before calling of_graph_get_port_parent().

Tested with kernel v4.13-rc2 with hikey_defconfig taken from
branch dev/hikey-mainline-WIP

v1 -> v2:
- modify subject "s/fix balance of/fix unbalanced/";
- split the patch per each individual issue. It also simplify the
- add ref to the commit being fixed;
- drop one fix not needed.

Antonio Borneo (3):
ASoC: fix use of of_node_put() in of_for_each_phandle() loops
ASoC: soc-core: fix unbalanced of_node_get()/of_node_put()
ASoC: simple-card-utils: fix unbalanced of_node_get()/of_node_put()

sound/soc/generic/audio-graph-card.c | 9 ++++-----
sound/soc/generic/simple-card-utils.c | 5 +++++
sound/soc/soc-core.c | 5 +++++
3 files changed, 14 insertions(+), 5 deletions(-)


 \ /
  Last update: 2017-07-28 01:36    [W:0.102 / U:1.860 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site