lkml.org 
[lkml]   [2017]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v4 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples
Date
Hello,

Currently the --show-total-period option of perf-annotate
is different from perf-report's.

It has two problem like below:
(Reported by Namhyung Kim and Milian Wolff)

1) Wrong column i.e. 'Percent' (even though using --show-total-period)
2) Show number of samples, not period

So fix this option on both the annotate stdio and TUI browser.
And support --show-nr-samples into perf-anntate
so that it correpond with perf-report's.

The code is available on 'perf/ann-fix-period-v4' branch at

git://github.com/taeung/linux-perf.git

Thanks,
Taeung

v4:
- Split big patches (Arnaldo)
- Initialize width for first column on the annotate browser (Arnaldo)

v3:
- Circulate the three view (Percent, Event count, Samples) (Namhyung)
- Calculate the percent with period or number of samples (Namhyung)

v2:
- Separate the first patch into respective paches for easy review (Arnaldo)
- Add a patch to introduce 'struct sym_hist_entry' (Arnaldo)
- disasm__calc_percent() could receive a pointer to a struct sym_hist_entry
instead of two pointer (Arnaldo)
- Add a sym_hist_entry into struct disasm_line_samples (Arnaldo)
- Fix a case that can't switch 'the total period view' to
'the number of samples view' on the annotate TUI browser (Arnaldo)
- Calculate the percentage with 'period', not number of samples

Taeung Song (9):
perf annotate: Widen "Event count" column when using
--show-total-period
perf annotate: Initialize proper width for first column
perf anntoate browser: Fix the toggle total period view showing number
of samples
perf annotate browser: Show the proper header when using
--show-total-period
perf annotate stdio: Support --show-nr-samples option
perf annotate browser: Support --show-nr-samples option
perf annotate browser: Circulate percent, total period, samples view
perf annotate: Check total period before calculating percent
perf annotate: Calculate the percentage with period or number of
samples

tools/perf/builtin-annotate.c | 2 ++
tools/perf/ui/browsers/annotate.c | 50 +++++++++++++++++++++++++++++----------
tools/perf/util/annotate.c | 35 ++++++++++++++++++---------
3 files changed, 64 insertions(+), 23 deletions(-)

--
2.7.4

\
 
 \ /
  Last update: 2017-07-27 18:16    [W:0.031 / U:0.080 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site