Messages in this thread | | | From | Punit Agrawal <> | Subject | Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot | Date | Thu, 27 Jul 2017 10:35:45 +0100 |
| |
Hi Boris,
Apologies for the delayed response. I somehow managed to lose updates on this thread.
Borislav Petkov <bp@suse.de> writes:
> On Thu, Jul 20, 2017 at 06:50:51PM +0100, Punit Agrawal wrote: >> "Firmware does not support APEI firmware first mode" >> >> Thoughts? > > I guess the simplest would be to add a third state to that hest_disable > to denote "HEST table not found" and then exit ghes_init() early, based on > checking it.
Although simple, won't it make the already convoluted code flow more so. Instead in addition to not setting hest_disable when the table is not found ...
> > Otherwise ghes_init() inits a bunch of things which you probably don't > want on a platform which doesn't support APEI.
... would you be open to a patch re-working the ghes driver initialisation to only do the platform driver registration. The the rest of the initialisation (including the apei_osc_setup and related messages) can be performed when the first ghes device gets probed.
Does that sound like a better alternative?
> > -- > Regards/Gruss, > Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
| |