[lkml]   [2017]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [v3] mm: Add SLUB free list pointer obfuscation
On Wed, Jul 26, 2017 at 9:55 AM, Christopher Lameter <> wrote:
> On Wed, 26 Jul 2017, Kees Cook wrote:
>> >> What happens if, instead of BUG_ON, we do:
>> >>
>> >> if (unlikely(WARN_RATELIMIT(object == fp, "double-free detected"))
>> >> return;
>> >
>> > This may work for the free fastpath but the set_freepointer function is
>> > use in multiple other locations. Maybe just add this to the fastpath
>> > instead of to this fucnction?
>> Do you mean do_slab_free()?
> Yes inserting these lines into do_slab_free() would simple ignore the
> double free operation in the fast path and that would be safe.
> Although in either case we are adding code to the fastpath...

While I'd like it unconditionally, I think Alexander's proposal was to

BTW, while I've got your attention, can you Ack the other patch? I
sent a v4 for the pointer obfuscation, which we really need:



Kees Cook
Pixel Security

 \ /
  Last update: 2017-07-26 19:14    [W:0.065 / U:0.664 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site