lkml.org 
[lkml]   [2017]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] fbdev: omapfb: remove unused variable
On Wed, Jul 26, 2017 at 04:31:38PM +0200, Arnd Bergmann wrote:
> On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > Hi,
> >
> > On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
> >> Removing the default display name left a harmless warning:
> >>
> >> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
> >> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
> >>
> >> This removes the now-unused variable as well.
> >>
> >> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> ---
> >> Originally submitted on June 9, no reply other than the Reviewed-by tag.
> >> The patch is still needed
> >
> > It is not lost and will be queued for 4.13 fbdev fixes pull request.
>
> Ok, thanks a lot!
>
> > [ The guilty commit went through DRM tree and pulling it into fbdev
> > tree just to fix the warning was not feasible.. ]
>
> Yes, I was originally hoping the fix could be merged along with the
> patch that introduced the bug. I may have messed up the Cc list for that
> though.

Should we add dri-devel as an mailing list entry to the fbdev system in
MAINTAINERS? Iirc there's almost no traffic for fbdev itself, and this
would avoid such a fumble in the future.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2017-07-26 16:51    [W:0.070 / U:1.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site