lkml.org 
[lkml]   [2017]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] smp_call_function: use inline helpers instead of macros
On Wed, Jul 26, 2017 at 4:42 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 26/07/2017 15:32, Arnd Bergmann wrote:
>> A new caller of smp_call_function() passes a local variable as the 'wait'
>> argument, and that variable is otherwise unused, so we get a warning
>> in non-SMP configurations:
>>
>> virt/kvm/kvm_main.c: In function 'kvm_make_all_cpus_request':
>> virt/kvm/kvm_main.c:195:7: error: unused variable 'wait' [-Werror=unused-variable]
>> bool wait = req & KVM_REQUEST_WAIT;
>>
>> This addresses the warning by changing the two macros into inline functions.
>> As reported by the 0day build bot, a small change is required in the MIPS
>> r4k code for this, which then gets a warning about a missing variable.
>>
>> Fixes: 7a97cec26b94 ("KVM: mark requests that need synchronization")
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Link: https://patchwork.kernel.org/patch/9722063/
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> This is not needed anymore, I've fixed it in KVM:
>
> commit b49defe83659cefbb1763d541e779da32594ab10
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date: Fri Jun 30 13:25:45 2017 +0200
>
> kvm: avoid unused variable warning for UP builds

Ok, that seems sufficient, thanks!

Arnd

\
 
 \ /
  Last update: 2017-07-26 16:50    [W:0.033 / U:1.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site