lkml.org 
[lkml]   [2017]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] irqchip: create a Kconfig menu for irqchip drivers
From
Date
On 26/07/17 05:03, Masahiro Yamada wrote:
> Some irqchip drivers have a Kconfig prompt. When we run menuconfig
> or friends, those drivers are directly listed in the "Device Drivers"
> menu level. This does not look nice. Create a sub-system level menu.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/irqchip/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index f1fd5f44d1d4..7b66313a2952 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -1,3 +1,5 @@
> +menu "IRQ chip support"
> +
> config IRQCHIP
> def_bool y
> depends on OF_IRQ
> @@ -306,3 +308,5 @@ config QCOM_IRQ_COMBINER
> help
> Say yes here to add support for the IRQ combiner devices embedded
> in Qualcomm Technologies chips.
> +
> +endmenu
>

I'm very reluctant to introduce this. IMHO, interrupt controllers are
way too low level a thing to let them be selected by the user. They
really should be selected by the platform that needs them

Do you have any example in mind where having a user-selectable interrupt
controller actually makes sense on its own?

Thanks,

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2017-07-26 10:05    [W:0.700 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site