lkml.org 
[lkml]   [2017]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/14] amdgpu: powerplay: Remove unused function
    From
    Date
    On 2017-07-24 09:35 AM, Ricardo Ribalda Delgado wrote:
    > amd_powerplay_display_configuration_change is never called.
    >
    > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
    > ---
    > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 21 ---------------------
    > drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h | 3 ---
    > 2 files changed, 24 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
    > index f73e80c4bf33..1ee7aa5546bf 100644
    > --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
    > +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
    > @@ -1237,27 +1237,6 @@ int amd_powerplay_reset(void *handle)
    > return pem_handle_event(eventmgr, AMD_PP_EVENT_COMPLETE_INIT, &event_data);
    > }
    >
    > -/* export this function to DAL */
    > -
    > -int amd_powerplay_display_configuration_change(void *handle,
    > - const struct amd_pp_display_configuration *display_config)

    This is used and needed by the DC display driver. See
    display/amdgpu_dm/amdgpu_dm_services.c:193 in Alex's amd-staging-4.11 tree:

    https://cgit.freedesktop.org/~agd5f/linux/tree/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c?h=amd-staging-4.11

    Harry

    > -{
    > - struct pp_hwmgr *hwmgr;
    > - struct pp_instance *pp_handle = (struct pp_instance *)handle;
    > - int ret = 0;
    > -
    > - ret = pp_check(pp_handle);
    > -
    > - if (ret != 0)
    > - return ret;
    > -
    > - hwmgr = pp_handle->hwmgr;
    > - mutex_lock(&pp_handle->pp_lock);
    > - phm_store_dal_configuration_data(hwmgr, display_config);
    > - mutex_unlock(&pp_handle->pp_lock);
    > - return 0;
    > -}
    > -
    > int amd_powerplay_get_display_power_level(void *handle,
    > struct amd_pp_simple_clock_info *output)
    > {
    > diff --git a/drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h b/drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h
    > index 07e9c0b5915d..ae49af5cc5d1 100644
    > --- a/drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h
    > +++ b/drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h
    > @@ -407,9 +407,6 @@ int amd_powerplay_destroy(void *handle);
    >
    > int amd_powerplay_reset(void *handle);
    >
    > -int amd_powerplay_display_configuration_change(void *handle,
    > - const struct amd_pp_display_configuration *input);
    > -
    > int amd_powerplay_get_display_power_level(void *handle,
    > struct amd_pp_simple_clock_info *output);
    >
    >

    \
     
     \ /
      Last update: 2017-07-24 16:02    [W:4.229 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site