lkml.org 
[lkml]   [2017]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/9] tty: synclink: constify pci_device_id.
    Date
    pci_device_id are not supposed to change at runtime. All functions
    working with pci_device_id provided by <linux/pci.h> work with
    const pci_device_id. So mark the non-const structs as const.

    File size before:
    text data bss dec hex filename
    51755 400 513 52668 cdbc drivers/tty/synclink.o

    File size After adding 'const':
    text data bss dec hex filename
    51883 304 513 52700 cddc drivers/tty/synclink.o

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    drivers/tty/synclink.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c
    index 3fafc5a..3be9811 100644
    --- a/drivers/tty/synclink.c
    +++ b/drivers/tty/synclink.c
    @@ -884,7 +884,7 @@ static int synclink_init_one (struct pci_dev *dev,
    const struct pci_device_id *ent);
    static void synclink_remove_one (struct pci_dev *dev);

    -static struct pci_device_id synclink_pci_tbl[] = {
    +static const struct pci_device_id synclink_pci_tbl[] = {
    { PCI_VENDOR_ID_MICROGATE, PCI_DEVICE_ID_MICROGATE_USC, PCI_ANY_ID, PCI_ANY_ID, },
    { PCI_VENDOR_ID_MICROGATE, 0x0210, PCI_ANY_ID, PCI_ANY_ID, },
    { 0, }, /* terminate list */
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-07-23 12:04    [W:2.894 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site