lkml.org 
[lkml]   [2017]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] perf script: remove some bogus error handling
If script_desc__new() fails then the current code has a NULL
dereference. We don't actually need to do any cleanup, we can just
return NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 83cdc0a61fd6..89ea2bc9b9be 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2199,16 +2199,11 @@ static struct script_desc *script_desc__findnew(const char *name)

s = script_desc__new(name);
if (!s)
- goto out_delete_desc;
+ return NULL;

script_desc__add(s);

return s;
-
-out_delete_desc:
- script_desc__delete(s);
-
- return NULL;
}

static const char *ends_with(const char *str, const char *suffix)
\
 
 \ /
  Last update: 2017-07-22 09:37    [W:0.076 / U:15.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site