Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 22 Jul 2017 04:52:15 +0300 | Subject | Re: [PATCH v3 5/5] ACPI / boot: Don't handle SCI on HW reduced platforms |
| |
On Sat, Jul 22, 2017 at 1:28 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, July 18, 2017 06:04:20 PM Andy Shevchenko wrote: >> As per note in 5.2.9 Fixed ACPI Description Table (FADT) chapter of ACPI >> specification OSPM will ignore fields related to the ACPI HW register >> interface, one of which is SCI_INT. >> >> Follow the spec and ignore any configuration done for interrupt line >> defined by SCI_INT if FADT specifies HW reduced platform.
> Can we invalidate acpi_gbl_FADT.sci_interrupt somehow for > acpi_gbl_reduced_hardware?
At some point there INVALID_ACPI_IRQ is used. There is also helper to check it acpi_sci_irq_valid().
So, we can use that helper instead.
> The checks added below look somewhat arbitrary and it would be good to > provide some argumentation on why everything is covered by them as needed.
-- With Best Regards, Andy Shevchenko
| |