lkml.org 
[lkml]   [2017]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions
On 07/21/17 at 07:37pm, Ingo Molnar wrote:
>
> * Baoquan He <bhe@redhat.com> wrote:
>
> > > > +static inline bool process_efi_entries(unsigned long minimum,
> > > > + unsigned long image_size)
> > >
> > > ugly linebreak again ...
> >
> > The whole line is more than 80. I break the line and use tab and space
> > to make it align with above 'unsigned long minimum'. Don't know why it
> > becomes messy in patch. Will check and try again.
>
> Then make the linebreak less ugly, or ignore the checkpatch warning!
>
> This commonly used pattern:
>
> static inline bool
> process_efi_entries(unsigned long minimum, unsigned long image_size)
>
> looks a lot better than the function parameter list broken in the middle.

Got it, will use this one. Thanks a lot!

\
 
 \ /
  Last update: 2017-07-22 01:44    [W:0.366 / U:1.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site