lkml.org 
[lkml]   [2017]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver
On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote:
> register_console() is called from
> uart_add_one_port()->uart_configure_port()
> that's why register_console() is called twice.
>
> This patch remove console_initcall to call register_console() only from
> one location.
>
> Also based on my tests cdns_uart_console_setup() is not called
> from the first register_console() call.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> I am not quite sure about this because console_initcall is called
> early but I can see any difference in usage.
> pl011 is not calling this but others are doing it.

Doesn't this break early console/printk? I would expect that the UART
initialization may happen later than console init.

Sören

\
 
 \ /
  Last update: 2017-07-21 17:48    [W:0.065 / U:4.232 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site