lkml.org 
[lkml]   [2017]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] pinctrl: rockchip: Use common interface for recalced iomux
Date
Am Freitag, 21. Juli 2017, 14:27:14 CEST schrieb David Wu:
> The other Socs also need the feature of recalced iomux, so
> make it as a common interface like iomux route feature.
>
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 89 +++++++++++++++++++++-----------------
> 1 file changed, 50 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index e831647..fd4e491 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -76,7 +76,6 @@ enum rockchip_pinctrl_type {
> #define IOMUX_SOURCE_PMU BIT(2)
> #define IOMUX_UNROUTED BIT(3)
> #define IOMUX_WIDTH_3BIT BIT(4)
> -#define IOMUX_RECALCED BIT(5)

very cool to see this flag go away and simply calculating the affected
bits is obviously a way nicer solution.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Thanks for that cleanup
Heiko

\
 
 \ /
  Last update: 2017-07-21 11:36    [W:0.047 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site