lkml.org 
[lkml]   [2017]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe
From
Date


On 07/20/2017 05:28 PM, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Thu, 20 Jul 2017 11:08:09 -0500
>
>> In general patch looks good to me, but it's really unexpected to
>> receive IRQs while CPSW is probing ;(
>
> This is a poor expectation.
>
> Boot loaders and other entities can leave the device in any state
> whatsoever.
>
> Furthermore, enabling an IRQ whose handler cannot properly execute
> without crashing is wrong fundamentally. All data structures and
> state must be set up properly before the IRQ is requested.
>
> Therefore this patch is correct and I will apply it.
>

Thanks. Agree (it just has never triggered before, so I meant - unexpected
from current driver code point of view ;().
And I'm just worry that it might not be enough :(, especially for am335x.

--
regards,
-grygorii

\
 
 \ /
  Last update: 2017-07-21 00:45    [W:0.112 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site