lkml.org 
[lkml]   [2017]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/28] video: fbdev: radeon: constify pci_device_id.
    Date
    pci_device_id are not supposed to change at runtime. All functions
    working with pci_device_id provided by <linux/pci.h> work with
    const pci_device_id. So mark the non-const structs as const.

    File size before:
    text data bss dec hex filename
    19709 5024 32 24765 60bd video/fbdev/aty/radeon_base.o

    File size After adding 'const':
    text data bss dec hex filename
    22893 1840 32 24765 60bd video/fbdev/aty/radeon_base.o

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    drivers/video/fbdev/aty/radeon_base.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
    index 6b4c787..dba479e 100644
    --- a/drivers/video/fbdev/aty/radeon_base.c
    +++ b/drivers/video/fbdev/aty/radeon_base.c
    @@ -96,7 +96,7 @@
    #define CHIP_DEF(id, family, flags) \
    { PCI_VENDOR_ID_ATI, id, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (flags) | (CHIP_FAMILY_##family) }

    -static struct pci_device_id radeonfb_pci_table[] = {
    +static const struct pci_device_id radeonfb_pci_table[] = {
    /* Radeon Xpress 200m */
    CHIP_DEF(PCI_CHIP_RS480_5955, RS480, CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
    CHIP_DEF(PCI_CHIP_RS482_5975, RS480, CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-07-20 23:25    [W:8.716 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site