Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH 23/28] video: fbdev: gxfb: constify pci_device_id. | Date | Thu, 20 Jul 2017 23:09:48 +0530 |
| |
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const.
File size before: text data bss dec hex filename 2643 1616 16 4275 10b3 video/fbdev/geode/gxfb_core.o
File size After adding 'const': text data bss dec hex filename 2707 1552 16 4275 10b3 video/fbdev/geode/gxfb_core.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/video/fbdev/geode/gxfb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/geode/gxfb_core.c b/drivers/video/fbdev/geode/gxfb_core.c index ec9fc9a..f4f7637 100644 --- a/drivers/video/fbdev/geode/gxfb_core.c +++ b/drivers/video/fbdev/geode/gxfb_core.c @@ -474,7 +474,7 @@ static void gxfb_remove(struct pci_dev *pdev) framebuffer_release(info); } -static struct pci_device_id gxfb_id_table[] = { +static const struct pci_device_id gxfb_id_table[] = { { PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_GX_VIDEO) }, { 0, } }; -- 2.7.4
| |