lkml.org 
[lkml]   [2017]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test
On Thu, Jul 20, 2017 at 10:56 AM, Christoph Hellwig <hch@lst.de> wrote:
> Fixes: df33767d ("uuid: hoist helpers uuid_equal() and uuid_copy() from xfs")
> Reported-by: kernel test robot <xiaolong.ye@intel.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Oops
Reviewed-by: Amir Goldstein <amir73il@gmail.com>


> ---
> lib/test_uuid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_uuid.c b/lib/test_uuid.c
> index 478c049630b5..cd819c397dc7 100644
> --- a/lib/test_uuid.c
> +++ b/lib/test_uuid.c
> @@ -82,7 +82,7 @@ static void __init test_uuid_test(const struct test_uuid_data *data)
> test_uuid_failed("conversion", false, true, data->uuid, NULL);
>
> total_tests++;
> - if (uuid_equal(&data->be, &be)) {
> + if (!uuid_equal(&data->be, &be)) {
> sprintf(buf, "%pUb", &be);
> test_uuid_failed("cmp", false, true, data->uuid, buf);
> }
> --
> 2.11.0
>

\
 
 \ /
  Last update: 2017-07-20 23:19    [W:0.131 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site