lkml.org 
[lkml]   [2017]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] can: dev: Add support for limiting configured bitrate
From
Date
Hi Franklin,

On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote:

> +#ifdef CONFIG_OF
> +void of_transceiver_is_fixed(struct net_device *dev)
> +{

(..)

> +}
> +EXPORT_SYMBOL(of_transceiver_is_fixed);
> +#endif

I'm not sure about the naming here.

As this is a CAN transceiver related option it should be named accordingly:

E.g.

can_transceiver_is_fixed
of_can_transceiver_is_fixed
...

Especially as it is defined in include/linux/can/dev.h

Regards,
Oliver


\
 
 \ /
  Last update: 2017-07-20 23:19    [W:0.238 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site