lkml.org 
[lkml]   [2017]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 03/12] staging: lustre: llite: fix various issues with ll_splice_alias.
On Tue, Jul 18 2017, Oleg Drokin wrote:

> Unfortunately this patch causes insta-crash on first stat call after mount.
> Sorry, I cannot dig into this deeper right this moment, but I will a bit later.

V.strange. The crash suggests that the lock, and hence the inode, is
not initialized. I cannot see how that might happen.
though...

>> + spin_lock(&lli->lli_lock);
>> + new = ll_find_invalid_alias(inode, de);
>> + if (!new)
>> + d_add(de, inode);
>> + spin_lock(&lli->lli_lock);

Had it not crashed, it would have deadlocked. That second spin_lock()
should be spin_unlock() :-( I don't *think* that would have caused this crash...

> I am adding Al that we discussed this code at some length and he found no problems
> here, so I am a bit surprised by your findings.

I'd be very happy to read Al's thoughts.

> Also the reason we reinvent the d_splice_alias is because we need to
> splice not just directories, but also regular files.

I see that. A key simplification I bring is that directories and
non-directories can be handled separately. d_splice_alias() does
all we need for directories, and nothing useful for non-dirs.

Thanks,
NeilBrown
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-07-19 06:34    [W:0.069 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site