lkml.org 
[lkml]   [2017]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay
On Wed, Jul 19, 2017 at 05:36:28AM -0700, Joe Perches wrote:
> On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote:
> > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
> []
> > diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
> []
> > @@ -28,7 +28,7 @@
> >
> > #define DRV_VERSION "2.10"
> > #define SYNTH_IO_EXTENT 0x04
> > -#define SWAIT udelay(70)
> > +#define SWAIT usleep_range(70, 150)
>
> It'd probably be more sensible to remove this define as
> SWAIT is used just once and use usleep_range directly.
>

I asked for that last time :(

I guess I'll just reject this again...

\
 
 \ /
  Last update: 2017-07-19 14:46    [W:0.058 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site