Messages in this thread | | | Subject | Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay | From | Joe Perches <> | Date | Wed, 19 Jul 2017 05:36:28 -0700 |
| |
On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote: > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; [] > diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c [] > @@ -28,7 +28,7 @@ > > #define DRV_VERSION "2.10" > #define SYNTH_IO_EXTENT 0x04 > -#define SWAIT udelay(70) > +#define SWAIT usleep_range(70, 150)
It'd probably be more sensible to remove this define as SWAIT is used just once and use usleep_range directly.
| |