Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 19 Jul 2017 11:16:04 +0200 | Subject | Re: [PATCH] spi: Convert to using %pOF instead of full_name |
| |
On Tue, Jul 18, 2017 at 11:43 PM, Rob Herring <robh@kernel.org> wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1583,8 +1583,8 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi, > > if (spi_controller_is_slave(ctlr)) { > if (strcmp(nc->name, "slave")) { > - dev_err(&ctlr->dev, "%s is not called 'slave'\n", > - nc->full_name); > + dev_err(&ctlr->dev, "%pOF is not called 'slave'\n", > + nc);
I think this can be merged in a single line (more below).
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |