Messages in this thread | | | Subject | Re: [PATCH v2 7/7] Input: axp20x-pek - switch to using devm_device_add_group() | From | Guenter Roeck <> | Date | Wed, 19 Jul 2017 20:21:39 -0700 |
| |
On 07/19/2017 05:24 PM, Dmitry Torokhov wrote: > Now that we have proper managed API to create device attributes, let's > use it instead of installing a custom devm action. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/input/misc/axp20x-pek.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x-pek.c > index 38c79ebff033..cfeb0e943de6 100644 > --- a/drivers/input/misc/axp20x-pek.c > +++ b/drivers/input/misc/axp20x-pek.c > @@ -182,13 +182,6 @@ static irqreturn_t axp20x_pek_irq(int irq, void *pwr) > return IRQ_HANDLED; > } > > -static void axp20x_remove_sysfs_group(void *_data) > -{ > - struct device *dev = _data; > - > - sysfs_remove_group(&dev->kobj, &axp20x_attribute_group); > -} > - > static int axp20x_pek_probe_input_device(struct axp20x_pek *axp20x_pek, > struct platform_device *pdev) > { > @@ -313,22 +306,13 @@ static int axp20x_pek_probe(struct platform_device *pdev) > return error; > } > > - error = sysfs_create_group(&pdev->dev.kobj, &axp20x_attribute_group); > + error = devm_device_add_group(&pdev->dev, &axp20x_attribute_group); > if (error) { > dev_err(&pdev->dev, "Failed to create sysfs attributes: %d\n", > error); > return error; > } > > - error = devm_add_action(&pdev->dev, > - axp20x_remove_sysfs_group, &pdev->dev); > - if (error) { > - axp20x_remove_sysfs_group(&pdev->dev); > - dev_err(&pdev->dev, "Failed to add sysfs cleanup action: %d\n", > - error); > - return error; > - } > - > platform_set_drvdata(pdev, axp20x_pek); > > return 0; >
| |