lkml.org 
[lkml]   [2017]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch
On Tue, Jul 18, 2017 at 3:37 PM,  <laurentiu.tudor@nxp.com> wrote:

> --- a/drivers/staging/fsl-dpaa2/Kconfig
> +++ b/drivers/staging/fsl-dpaa2/Kconfig
> @@ -4,7 +4,7 @@
>
> config FSL_DPAA2
> bool "Freescale DPAA2 devices"
> - depends on FSL_MC_BUS
> + depends on FSL_MC_BUS && ARCH_LAYERSCAPE
> ---help---
> Build drivers for Freescale DataPath Acceleration
> Architecture (DPAA2) family of SoCs.

I would probably leave the dependency in there conditionally, like

depends on ARCH_LAYERSCAPE || COMPILE_TEST

That way, we can build the driver on all architectures with "make allmodconfig"
or "make randconfig", but regular users that disable COMPILE_TEST
won't be bothered by the extra config options unless they have the
right hardware.

Arnd

\
 
 \ /
  Last update: 2017-07-18 16:26    [W:0.233 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site