Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check | Date | Tue, 18 Jul 2017 14:04:00 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
The check for thread_run failure is incorrect, use IS_ERR instead.
Cleans up sparse error message: "error: incompatible types for operation (<)"
Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 95930a192de4..266e572ae66e 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1152,8 +1152,7 @@ static int pi433_probe(struct spi_device *spi) device->tx_task_struct = kthread_run(pi433_tx_thread, device, "pi433_tx_task"); - if (device->tx_task_struct < 0) - { + if (IS_ERR(device->tx_task_struct)) { dev_dbg(device->dev, "start of send thread failed"); goto send_thread_failed; } -- 2.11.0
| |